Start removing dependency from FhirVersionEnum to FhirContext #6512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelabuckley
requested review from
jamesagnew,
nathandoef and
tadgh
as code owners
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6512 +/- ##
============================================
- Coverage 83.54% 83.47% -0.07%
- Complexity 27432 27882 +450
============================================
Files 1707 1754 +47
Lines 106185 108180 +1995
Branches 13397 13570 +173
============================================
+ Hits 88710 90303 +1593
- Misses 11750 12039 +289
- Partials 5725 5838 +113 ☔ View full report in Codecov by Sentry. |
jamesagnew
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our model classes use FhirVersionEnum, and the path from there to FhirContext brings in the whole world.
Snip this path to start disentangling the core libraries from hapi-fhir.