Drop tag definition constraint#6582
Merged
Merged
Conversation
|
Formatting check succeeded! |
michaelabuckley
approved these changes
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6582 +/- ##
============================================
- Coverage 83.54% 83.50% -0.04%
- Complexity 27432 28564 +1132
============================================
Files 1707 1797 +90
Lines 106185 111156 +4971
Branches 13397 13964 +567
============================================
+ Hits 88710 92822 +4112
- Misses 11750 12347 +597
- Partials 5725 5987 +262 ☔ View full report in Codecov by Sentry. |
jamesagnew
added a commit
that referenced
this pull request
Jan 17, 2025
jamesagnew
added a commit
that referenced
this pull request
Jan 17, 2025
* Drop tag definition constraint * Add changelog * Add tests * Add tests * Test fix * Also drop resource link target FK * Spotless * Only drop HFJ_RES_LINK target FK when we're on Postgres/MSSQL/Oracle mode * Cleanup and test fixes * Missing commit for #6582 * Clean up pom * Spotless
hankwallace
added a commit
to elimuinformatics/hapi-fhir
that referenced
this pull request
Apr 20, 2026
* Add result column to migration table (hapifhir#6580) * add skipped flag * switch to string * changelog * changelog * migrate table * migrate table * spotless * merge master * exception code * exception code * fix regression * fix change log (hapifhir#6592) * tests fail on new version of derby (hapifhir#6591) * fix change log (hapifhir#6593) * Optmize prefetch for mass ingestion transactions (hapifhir#6589) * Optmize prefetch for mass ingestion transactions * Add changelog * Spotless * Resolve review comments and spotless * remove package-mode from poetry (hapifhir#6595) * Release V7_6_1 mergeback (hapifhir#6571) * Enhance vital signs narrative generation (hapifhir#6590) * add support for formatting observation.component entries in vital signs narrative generation * update * store raw json to allow validation to be the same on create as in $validate (hapifhir#6585) store text raw resource * Jr 20241217 refine ips templates (hapifhir#6597) * clean up procedures template * immunization WIP * complete conversion of immunization template * medication template * fix broken integration test * template for history of illness * problem list template * Validate resource type on FHIR transaction updates (hapifhir#6600) * Validate resource type on FHIR transaction updates * Add changelgo * Spotless * social history template (hapifhir#6604) * added new narrative generator utility method (hapifhir#6602) * added new narrative generator utility method * added another helper method * updated test * render datetype (hapifhir#6613) * Add cds hooks fhir server to the BOM (hapifhir#6622) * Issue with combo index search parameter when using date (hapifhir#6566) * WIP: commenting out default value assignement for the dateParam prefix. The purpose is to run the 'fix' through the pipelines to see what fails. * spotless * fixing spotless * updated solution and tests * fixing tests * adding changelog * fixing comment for clarity. * fixing changelog filename * spotless * addressing comments from code review. * addressing comments from second code review. * providing new solution where = and =eq should yield the same behavior. * spotless happiness. --------- Co-authored-by: peartree <etienne.poirier@smilecdr.com> * Drop tag definition constraint (hapifhir#6582) * Drop tag definition constraint * Add changelog * Add tests * Add tests * Test fix * Also drop resource link target FK * Spotless * Only drop HFJ_RES_LINK target FK when we're on Postgres/MSSQL/Oracle mode * Cleanup and test fixes * Missing commit for hapifhir#6582 (hapifhir#6627) * Drop tag definition constraint * Add changelog * Add tests * Add tests * Test fix * Also drop resource link target FK * Spotless * Only drop HFJ_RES_LINK target FK when we're on Postgres/MSSQL/Oracle mode * Cleanup and test fixes * Missing commit for hapifhir#6582 * Clean up pom * Spotless * delete gr when deleting final resource on partition (hapifhir#6619) * renamed $replace-references operation (hapifhir#6617) * Moving checks from azure to gh actions (hapifhir#6606) This commit adds a workflow, with associated actions to build and test HAPI, then upload the coverage results to CODECOV. This was previously done on Azure Pipelines. * Update pull-request.yml Changing trigger to PR on master. * Resolve deadlock in subscription registry (hapifhir#6632) * Resolve deadlock in subscription registry * Add changelog * remove use of maven.multiModuleProjectDirectory (hapifhir#6625) * first attempt. expecting issues. * move checkstyle config to resources folder * bump checkstyle version --------- Co-authored-by: Ken Stevens <ken@smiledigitalhealth.com> * group chapters by chapter type (hapifhir#6609) * test moving chapter to new type also fix auto collapse * copyright --------- Co-authored-by: Ken Stevens <ken@smiledigitalhealth.com> * code coverage fix for PR pipeline * Add replaces and replaced-by extensions (hapifhir#6636) * add new extensions * spotless * fix sonatype repo id (hapifhir#6640) * Add SCM branch to build properties (hapifhir#6642) * added cds hooks prefetch pointcuts (hapifhir#6639) * added cds hooks prefetch pointcuts * add prefixes to params * added strategy enum to pointcuts * add CdsHooksPrefetchContext to pointcuts that contains the query, template and userData to hold data between request/response pointcut invocations * pointcut api cleanup * spotless --------- Co-authored-by: nathaniel.doef <nathaniel.doef@smilecdr.com> * 6629 clinical reasoning version bump 317 (hapifhir#6631) * version bump clinical-reasoning for testing integration * changelog * bump CR to release 3.17.0 * bump hapi to 7.7.18-SNAPSHOT * removing invalid measure example * setup license * allow deleting resources if references are all versioned only (hapifhir#6645) * Rel 8 0 cves (hapifhir#6655) * Bump logback core for https://nvd.nist.gov/vuln/detail/CVE-2024-12798 * Bump UCUM for GHSA-w9j7-phm3-f97j * 6662 remote terminology boolean properties as string (hapifhir#6663) * Add test for failing use case and fix by adding Boolean property for remote validation * changelog * Revert not yet supported change * fix fhir patch replace in a list (hapifhir#6657) * Automated Migration Testing (HAPI-FHIR) - updated test migration scripts for 7_8_0 (hapifhir#6668) * Fix NPE in Storage with Mass Ingestion and Compartment Interceptor (hapifhir#6598) * add tests and fix mass ingestion and patient compartment interceptor compatibility in mass ingestion mode * changelogs * address review - add parameter class for method with 10 params * spotless --------- Co-authored-by: jdar <justin.dar@smiledigitalhealth.com> Co-authored-by: Kevin Dougan <72025369+KevinDougan@users.noreply.github.com> * SearchParameter validation was not being skipped on updates, even if … (hapifhir#6667) * SearchParameter validation was not being skipped on updates, even if requested. This has been fixed * spotless fixes * removed unecessary code * reverting the code back * added external JIRA ref * fix high cardinality field patching in replace-references (hapifhir#6671) * made $hapi.fhir.replace-references not replace versioned references (hapifhir#6684) * made replace-references not replace versioned references * Provide access to the wrapped ConsentService delegates for testing (hapifhir#6694) Add getters to delegating ConsentService classes * Fix _security label filtering with :not operator in the in-memory matcher (hapifhir#6691) * failing test * narrow failing test * fix * changelog * clean up * spotless * 6673 fixing search builder with fulltext search (hapifhir#6674) * Fixed an issue with the _lastUpdated search param not being recognised as a valid sort spec with Elastic Search enabled. (hapifhir#6670) * added test for '-delt-add' in hapi * fixed an issue with the _lastUpdated search param not being recognized as a valid sort spec with Hsearch enabled in CDR * added null check * added tests * added comments * addressed comments * updated static class property name * modified test * added changelog and addressed more comments * ran mvn spotless * addressed comments * ran mvn spotless * addressed comments --------- Co-authored-by: Abayomi Adebowale <abayomi.adebowale@smiledigitalhealth.com> * Fixing Failure when creating a cross-partition subscription if the default partition id is not null (hapifhir#6687) * initial test, solution and changelog * addressing comments from code review. * addressing code review comments and fixing tests. * addressing code analysis issues. * addressing code analysis issues. * fixing failing tests --------- Co-authored-by: peartree <etienne.poirier@smilecdr.com> * Account for case differences in DBPM contributor (hapifhir#6698) * Account for case differences in DBPM contributor * Test fix * Cleanup * Add flag to disable schema check (hapifhir#6699) * Add flag to disable schema check * Spotless * 6700 alternate api (hapifhir#6702) * Make the Canonicalizer non-null-default-partition-id aware * Rename test * Changelog * Rework * Remove dead IT * remove fixme * Move to 8.0.0 * licenses * Interim folder holder * 6711 everything operation with partitioning enabled returns duplicates since the dbpm merge (hapifhir#6712) * Add test stub * Changelog * Wording * Trying to get test working * Initial commit of tests and potential hash fix * Remove json file * Remove dead code * Remove dead test, spotless, fix changelog * Limitation * Version bump to 8.0 * With partitioning selection mode set to request tenant, creating a cross partition subscription will fail if the default partition id is not null (hapifhir#6748) * initial failing test * fix with changelog and modification to previous changelog --------- Co-authored-by: peartree <etienne.poirier@smilecdr.com> * revert the commenting-out of migrations * adds hapi-fhir-cli migrate-database arguments * update docs --------- Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: Mark Iantorno <markiantorno@gmail.com> Co-authored-by: James Agnew <jamesagnew@gmail.com> Co-authored-by: Tadgh <garygrantgraham@gmail.com> Co-authored-by: volodymyr-korzh <132366313+volodymyr-korzh@users.noreply.github.com> Co-authored-by: David Raeside <132376220+davidraeside@users.noreply.github.com> Co-authored-by: TipzCM <leif.stawnyczy@gmail.com> Co-authored-by: JasonRoberts-smile <85363818+JasonRoberts-smile@users.noreply.github.com> Co-authored-by: Etienne Poirier <33007955+epeartree@users.noreply.github.com> Co-authored-by: peartree <etienne.poirier@smilecdr.com> Co-authored-by: Emre Dincturk <74370953+mrdnctrk@users.noreply.github.com> Co-authored-by: Ken Stevens <ken@smiledigitalhealth.com> Co-authored-by: Nathan Doef <n.doef@protonmail.com> Co-authored-by: nathaniel.doef <nathaniel.doef@smilecdr.com> Co-authored-by: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com> Co-authored-by: jmarchionatto <60409882+jmarchionatto@users.noreply.github.com> Co-authored-by: jdar8 <69840459+jdar8@users.noreply.github.com> Co-authored-by: jdar <justin.dar@smiledigitalhealth.com> Co-authored-by: Kevin Dougan <72025369+KevinDougan@users.noreply.github.com> Co-authored-by: Buland Malik <bulandaltaf@gmail.com> Co-authored-by: Michael Buckley <michaelabuckley@gmail.com> Co-authored-by: Abayomi Adebowale <eyitouyoa3@gmail.com> Co-authored-by: Abayomi Adebowale <abayomi.adebowale@smiledigitalhealth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under heavy load, a foreign key constraint in the Tag Definition table (used for Tags, Security Labels, and Profile Definitions) can cause serious slowdowns when writing large numbers of resources (particularly if many resources contain the same tags/labels, or if the resources are being written individually or in smaller batches). This has been corrected.