Merged
Conversation
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6583 +/- ##
============================================
- Coverage 83.54% 83.47% -0.07%
- Complexity 27432 28521 +1089
============================================
Files 1707 1795 +88
Lines 106185 111059 +4874
Branches 13397 13953 +556
============================================
+ Hits 88710 92712 +4002
- Misses 11750 12367 +617
- Partials 5725 5980 +255 ☔ View full report in Codecov by Sentry. |
jmarchionatto
approved these changes
Jan 3, 2025
Collaborator
jmarchionatto
left a comment
jmarchionatto
left a comment
There was a problem hiding this comment.
Looks good. Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing a batch2 job under heavy load, a race condition meant that the final reducer step would occasionally fail if it started immediately following a batch2 maintenance task.