add language() and languages() #11
Conversation
|
|
||
| exports.charset = CharsetLib.charset; | ||
| exports.charsets = CharsetLib.charsets; | ||
|
|
||
| exports.encoding = EncodingLib.encoding; | ||
| exports.encodings = EncodingLib.encodings; | ||
|
|
||
| exports.language = LanguageLib.language; | ||
| exports.languages = LanguageLib.languages; |
There was a problem hiding this comment.
No need to have the Lib suffix on this variables.
There was a problem hiding this comment.
If I don't I'm going to have lines like this:
exports.language = Language.language;
Seems like a differentiator or some sort is a bonus for readability. It could be something else, but "lib" fits the bill and is short.
There was a problem hiding this comment.
I don't see what's wrong with the above. Looks better to me.
|
I've made the code style updates. I'm still trying to get the Hapi code style nailed down in my brain to spot these things. It's rough going between different projects with different styles. I'm punting for now on the map vs for loop question, but I've made an issue for it to determine whether there's an issue there or not, and I'll circle back around if there is. Anything else? |
|
I only reviewed style. If you want to get someone to review logic, that might be a good idea. |
|
@nlf Nathan, can you give the code here a once over? I believe the tests cover the desired output. |
| .map(internals.getParts) | ||
| .filter(internals.removeUnwanted) | ||
| .sort(internals.compareByWeight) | ||
| .map(internals.partToLanguage); |
There was a problem hiding this comment.
i feel like this could use some optimizing.. for now it's fine, but it's something to think about since it is something that potentially runs for every request.
|
Thanks Nathan. I'll leave this PR handing until I can come back and remove some of the functional programming where it makes sense. |
|
Decided instead to merge now and do a follow up issue for converting to functional style. I think that will work easier. |
add language() and languages()
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This provides parsing of the Accept-Language header, with a language() function to determine the proper language to respond with, and languages() to return back an ordered list of acceptable languages.