Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error codes in a separate file. Closes #13 #14

Merged
merged 3 commits into from Oct 16, 2019

Conversation

@nkint
Copy link

nkint commented Oct 14, 2019

Following comments in #13 .
I'm not totally sure if types test are correct.
Let me know if requires further changes, thank you.

lib/domain.js Show resolved Hide resolved
lib/domain.js Outdated Show resolved Hide resolved
@hueniverse hueniverse self-assigned this Oct 16, 2019
@hueniverse hueniverse added the feature label Oct 16, 2019
@hueniverse hueniverse added this to the 3.0.1 milestone Oct 16, 2019
@hueniverse hueniverse merged commit f349889 into hapijs:master Oct 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hueniverse added a commit that referenced this pull request Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.