Replace punycode dep with URL hack #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How come the test changed for one of the values? |
|
@kanongil Have you tested how that impacts joi's browser build ? Also punycode is (so far) part of node, I'm not surprised not to see it in dependencies. |
|
The test can be converted to punycode according to https://tools.ietf.org/html/rfc3492, but disallowed for IDNA according to https://tools.ietf.org/html/rfc5891#section-4.2.2. I don't think it matters much. |
|
Agreed. |
Closed
hueniverse
added a commit
that referenced
this pull request
Sep 5, 2019
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces the
punycodedependency with a clever hack that uses the WHATWG URL parsing logic to apply punycode decoding to the domain.I only changed it for the implementation itself, and not the test logic.
I also didn't remove it as a dependency, as it was missing, and only incidentally available in the
node_modulesfrom the eslint dependency.