Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace punycode dep with URL hack #4
Conversation
This comment has been minimized.
This comment has been minimized.
|
How come the test changed for one of the values? |
This comment has been minimized.
This comment has been minimized.
|
@kanongil Have you tested how that impacts joi's browser build ? Also punycode is (so far) part of node, I'm not surprised not to see it in dependencies. |
hueniverse
merged commit a920a92
into
hapijs:master
1 check was pending
1 check was pending
This comment has been minimized.
This comment has been minimized.
|
The test can be converted to punycode according to https://tools.ietf.org/html/rfc3492, but disallowed for IDNA according to https://tools.ietf.org/html/rfc5891#section-4.2.2. I don't think it matters much. |
This comment has been minimized.
This comment has been minimized.
|
Agreed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kanongil commentedSep 2, 2019
This patch replaces the
punycodedependency with a clever hack that uses the WHATWG URL parsing logic to apply punycode decoding to the domain.I only changed it for the implementation itself, and not the test logic.
I also didn't remove it as a dependency, as it was missing, and only incidentally available in the
node_modulesfrom the eslint dependency.