Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #18

Merged
merged 3 commits into from Apr 26, 2018

Conversation

@kanongil
Copy link
Member

kanongil commented Sep 26, 2017

Validates the range option, and emits error on internal errors.

The prevents uncaughtException when a new Ammo.Stream(null) is used.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 26, 2017

What is new Ammo.Stream(null) for?

@kanongil

This comment has been minimized.

Copy link
Member Author

kanongil commented Sep 26, 2017

It’s invalid, and should not be used. Now you get a thrown error when constructing instead.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 27, 2017

All these changes to handle something a simple assertion can do?

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Apr 21, 2018

Still looking to merge this?

@kanongil kanongil force-pushed the kanongil:improved-errors branch from 5cd9cbc to c25f3a3 Apr 26, 2018
@kanongil

This comment has been minimized.

Copy link
Member Author

kanongil commented Apr 26, 2018

I have split the patch into 3 commits to better illustrate what the patch does.

@kanongil kanongil closed this Apr 26, 2018
@kanongil kanongil reopened this Apr 26, 2018
@kanongil kanongil closed this Apr 26, 2018
@kanongil kanongil reopened this Apr 26, 2018
@kanongil kanongil merged commit 1b9800b into hapijs:master Apr 26, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kanongil kanongil self-assigned this Apr 29, 2018
@kanongil kanongil added the bug label Apr 29, 2018
@kanongil kanongil added this to the 3.0.1 milestone Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.