Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate decode/encode modules #12

Merged
merged 3 commits into from May 24, 2016

Conversation

@geek
Copy link
Member

geek commented May 21, 2016

No description provided.

@geek geek added the dependency label May 21, 2016
@geek geek added this to the 3.0.2 milestone May 21, 2016
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented May 21, 2016

Why?!

@geek

This comment has been minimized.

Copy link
Member Author

geek commented May 21, 2016

@hueniverse I find it easier to reason about when you separate the two. Look how simple encoder is now (54 lines).

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented May 21, 2016

This code is done. You really expect to spend time here?

@geek

This comment has been minimized.

Copy link
Member Author

geek commented May 21, 2016

@hueniverse good point. I hope that I don't have to. The only update I plan after this is to document the API. Hey, one nice benefit (other than simpler to read) will be if you only care about the encoder or decoder, you can include only that part :)

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented May 24, 2016

LGTM @geek

@geek geek merged commit 79deaba into hapijs:master May 24, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.