Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication fails when password contains one or more colons #11

Closed
zn8nz opened this issue Aug 1, 2014 · 0 comments
Closed

Authentication fails when password contains one or more colons #11

zn8nz opened this issue Aug 1, 2014 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@zn8nz
Copy link

@zn8nz zn8nz commented Aug 1, 2014

The split method chops the password into parts if the password contains a colon, then the total credentialsParts.length > 2. The HTTP Basic Authentication spec does not restrict passwords this way.

var credentialsParts = new Buffer(parts[1], 'base64').toString().split(':');
if (credentialsParts.length !== 2) {
return reply(Boom.badRequest('Bad header internal syntax', 'Basic'));
}

@hueniverse hueniverse added the bug label Aug 4, 2014
@hueniverse hueniverse added this to the 1.1.1 milestone Aug 4, 2014
@hueniverse hueniverse self-assigned this Aug 4, 2014
@hueniverse hueniverse closed this in 927d47b Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.