Skip to content

/basic

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node >= 4 / es2015 updates #42

Closed
mtharrison opened this issue Oct 29, 2015 · 4 comments
Closed

Node >= 4 / es2015 updates #42

mtharrison opened this issue Oct 29, 2015 · 4 comments
Assignees
@mtharrison
Labels
breaking changes
Milestone
4.0.0

Comments

@mtharrison
Copy link
Member

@mtharrison mtharrison commented Oct 29, 2015

Summary of changes required:

  • use strict
  • const and let where appropriate
  • arrow functions where appropriate
  • relevant updates to tests + docs
  • updating the engine in package.json
@mtharrison mtharrison self-assigned this Oct 29, 2015
@mtharrison mtharrison added this to the 4.0.0 milestone Oct 29, 2015
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member

@hueniverse hueniverse commented Nov 3, 2015

Also, avoid self and += / -= (not optimized yet for let const)
@devinivy

This comment has been minimized.

Sign in to view
Copy link
Member

@devinivy devinivy commented Nov 4, 2015

Are you saying that var should be used with self = this rather than let?
@mtharrison

This comment has been minimized.

Sign in to view
Copy link
Member Author

@mtharrison mtharrison commented Nov 4, 2015

@devinivy Avoiding altogether I think: hapijs/shot@129d6f6#diff-6d186b954a58d5bb740f73d84fe39073L83
@mtharrison mtharrison closed this in 0da82a6 Nov 4, 2015
@katherine-barn2door

This comment has been minimized.

Sign in to view
Copy link

@katherine-barn2door katherine-barn2door commented Jan 22, 2016

Is there a list of the breaking changes?

I found this was definitely breaking when I went from 2.x to 4.x. I'm wondering if there's anything else.

92b2e60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtharrison mtharrison

Labels
breaking changes
Projects
None yet
Milestone
  4.0.0
4 participants
@mtharrison @hueniverse @devinivy @katherine-barn2door
You can’t perform that action at this time.