Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update peerDependency #2

merged 2 commits into from Mar 21, 2014

update peerDependency #2

merged 2 commits into from Mar 21, 2014


Copy link

daviddias commented Mar 14, 2014

Simple PR, had to update the peerDependency, otherwise could not use with Hapi 3.0.

Tests say:

» npm test                  

> hapi-auth-basic@1.0.0 test /Users/david/Dropbox/Code/nodesecurity/hapi-auth-basic
> make test-cov


 22 tests complete (104 ms)

 No global variable leaks detected.

Coverage: 100.00%
Coverage succeeded

All seems pretty fine :) Also closes this one #1

@@ -19,10 +19,10 @@
"hoek": "1.x.x"
"peerDependencies": {
"hapi": "2.x.x"
"hapi": "3.x.x"

This comment has been minimized.

Copy link

pletcher Mar 14, 2014

Could this instead be ">=2.x.x" (and likewise below) to maintain backwards compatibility?

This comment has been minimized.

Copy link

daviddias Mar 14, 2014

Author Contributor

done :)

@hueniverse hueniverse added this to the 1.0.1 milestone Mar 21, 2014
@hueniverse hueniverse self-assigned this Mar 21, 2014
hueniverse added a commit that referenced this pull request Mar 21, 2014
update peerDependency
@hueniverse hueniverse merged commit e579edb into hapijs:master Mar 21, 2014
1 check passed
1 check passed
default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.