Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.resource() raw payload #193

Closed
hueniverse opened this issue Mar 4, 2016 · 0 comments
Closed

client.resource() raw payload #193

hueniverse opened this issue Mar 4, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Mar 4, 2016

Technically, the internals.parse() method in oauth.js is broken because it assumes JSON payload always starts with a { character. This is needed to hack around broken OAuth implementations that return the wrong payloads with or without proper content-encoding headers. But it will break some APIs. This fix allows turning off the parser. A better solution would be to make internal.parse() better to actually provide value (but I don't have the time for that). Either way, this is a useful option.

@hueniverse hueniverse added the feature label Mar 4, 2016
@hueniverse hueniverse self-assigned this Mar 4, 2016
@hueniverse hueniverse added this to the 7.0.0 milestone Mar 4, 2016
@hueniverse hueniverse modified the milestones: 7.0.0, 7.1.0 Mar 4, 2016
@hueniverse hueniverse closed this in a21dcc6 Mar 4, 2016
hueniverse added a commit that referenced this issue Mar 4, 2016
Support returning raw resource payload. Closes #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.