Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove dependency on Google Plus APIs #228
I was poking around to find out of there is a way to remove the dependency on Google Plus APIs now that Google is splitting Plus out of it's products. Reading Google's latest Identity Platform documentation, it seems that most endpoints are no longer associated with Google Plus at all.
While you can use a Google Identity auth key to call Google Plus APIs, such as requesting a users profile, Google Plus is not required for initial authentication. Additionally, the core APIs provide a way of getting a users basic information such as email address and given/family names.
Unfortunately, it appears that last year Bell moved in exactly the opposite direction #108. I suppose that's a side effect of Google making a big bet on Plus which didn't pan out in the end.
I believe the change required is just to modify the URL used to fetch the user profile https://github.com/hapijs/bell/blob/master/lib/providers/google.js#L13 and the code that parses out piece of the user profile (for example changing backward from
There are two reason I'm interested in doing this:
Before making such a PR, I wanted to post this issue just to gauge interest. Perhaps I'm wrong in assuming this is a desirable change? Some 3rd party auth systems implement an additional options parameter for Google for the userProfileUrl to use and implement two different parsers depending on the URL provided. Would Bill rather have that as a feature, taking into consideration that that's one more feature to maintain down the road?