Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bell 8.0.0 Release Notes #243

Closed
ldesplat opened this issue Jul 17, 2016 · 1 comment
Closed

Bell 8.0.0 Release Notes #243

ldesplat opened this issue Jul 17, 2016 · 1 comment
Labels
Milestone

Comments

@ldesplat
Copy link
Contributor

@ldesplat ldesplat commented Jul 17, 2016

Breaking Change

If you use the Google provider, it will not use Google+ to fetch user details anymore. If you want that functionality, then you muse use the googleplus which is the exact replica of the old google provider.

If you decide to continue using the google provider, do note that the profile response will look different and you must accommodate that change in your application.

See #228 and #235

Other Changes in this Release

  • New Fitbit provider (see #240)
  • providerParams and scope can now be synchronous functions that take in the request object and return an object to allow for more dynamic scenarios (see #233)
  • Upgraded Joi to 9.x.x releases

Hapijs organization uses Milestones to track changes. Even though major releases, warrant release notes, you can access all the previous releases and changes here: https://github.com/hapijs/bell/milestones?state=closed

Thank you everyone!

@ldesplat ldesplat added this to the 8.0.0 milestone Jul 17, 2016
@ldesplat ldesplat closed this Jul 17, 2016
@ericeslinger

This comment has been minimized.

Copy link

@ericeslinger ericeslinger commented Nov 2, 2016

I just recently upgraded to bell 8 (I don't revise dependencies often, since breaking changes are never fun).

As feedback, it would have been a ton easier for me if you'd have kept the google provider the same, and created a new provider called googleminus or something. In that case, I wouldn't be getting the more slim request against google auth scopes, but I would also not be getting a differently-formatted response either, and my code would have Just Kept Working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.