Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google user info #251

Closed
AdriVanHoudt opened this issue Aug 11, 2016 · 3 comments · Fixed by #254
Closed

Google user info #251

AdriVanHoudt opened this issue Aug 11, 2016 · 3 comments · Fixed by #254
Labels
bug
Milestone

Comments

@AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Aug 11, 2016

Recently the google provider changed to use the oauth user info instead of google plus user info.
But as far as I can tell from https://developers.google.com/identity/protocols/OpenIDConnect#obtainuserinfo the id is now mapped to the sub property but it was not changed in the PR see 19e37eb#diff-6cf5a5271f13794eed67d28ec16ffaa9L16

Am I doing something wrong or do you want a PR to fix this?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

@AdriVanHoudt AdriVanHoudt commented Aug 17, 2016

@ldesplat any comment on this?

@ldesplat

This comment has been minimized.

Copy link
Contributor

@ldesplat ldesplat commented Aug 20, 2016

I am running out of time to test this today, but yes i want a PR. Also, since this seems like a pretty bad bug if any Hapi contributor wants to merge this and make a patch release I would appreciate this. I'll be without access for 8 days.

Also, looks like the givenName and familyName is not applicable anymore. I really have to finish up my test repository for doing actual tests of each provider rather than these useless mocks.

Thank you and I am very sorry for the delay!

@ldesplat ldesplat added the bug label Aug 20, 2016
@ldesplat ldesplat added this to the 8.1.1 milestone Aug 20, 2016
AdriVanHoudt added a commit to AdriVanHoudt/bell that referenced this issue Aug 21, 2016
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

@AdriVanHoudt AdriVanHoudt commented Aug 21, 2016

@ldesplat PR is there!
The obvious downside to mocking certain calls is that if the provider changes it format the tests will never catch this, not sure how to solve this though.

ldesplat added a commit that referenced this issue Aug 21, 2016
fix mapping of google profile fixes #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.