Skip to content

/bell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or more comprehensively document provider.version #288

Closed
garthk opened this issue Jan 10, 2017 · 2 comments
Closed

Remove or more comprehensively document provider.version #288

garthk opened this issue Jan 10, 2017 · 2 comments
Assignees
@hueniverse
Labels
breaking changes feature
Milestone
9.1.0

Comments

@garthk
Copy link

@garthk garthk commented Jan 10, 2017

  • Defined in the API documentation as "the OAuth version"
  • Appears to be redundant given provider.protocol
  • Validated as a joi.string()
  • Doesn't appear to be used
@garthk

This comment has been minimized.

Sign in to view
Copy link
Author

@garthk garthk commented Jan 10, 2017

(In case it helps, I'm working on TypeScript support for bell.)
@ldesplat

This comment has been minimized.

Sign in to view
Copy link
Contributor

@ldesplat ldesplat commented Jan 26, 2017

Thanks, I'll take a look at depreciating this if it makes sense.
@hueniverse hueniverse added this to the 9.0.1 milestone Feb 26, 2018
@hueniverse hueniverse self-assigned this Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hueniverse hueniverse

Labels
breaking changes feature
Projects
None yet
Milestone
  9.1.0
3 participants
@garthk @ldesplat @hueniverse
You can’t perform that action at this time.