Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari isSameSite #395

Closed
flippidippi opened this issue Feb 11, 2019 · 3 comments
Closed

Safari isSameSite #395

flippidippi opened this issue Feb 11, 2019 · 3 comments
Labels
Milestone

Comments

@flippidippi
Copy link
Contributor

@flippidippi flippidippi commented Feb 11, 2019

I'm having redirect loops upon trying to login with Okta in Safari. I noticed that if I manually change isSameSite to 'Lax' or false in the cookieOptions for bell it fixes the issue.

Bell: 9.4.0
Hapi: 18.1.0
Hapi auth cookie: 9.1.0
Safari: 12.0.2

@flippidippi

This comment has been minimized.

Copy link
Contributor Author

@flippidippi flippidippi commented Feb 11, 2019

Seems like it might be related to https://bugs.webkit.org/show_bug.cgi?id=188165.

Possibly just adding the ability to change this setting similar to how bell allows changing isSecure and isHttpOnly would be useful.

@flippidippi

This comment has been minimized.

Copy link
Contributor Author

@flippidippi flippidippi commented Feb 12, 2019

@hueniverse This is effecting production stuff as it's related to Safari breaking something. Can we get this looked at soon? I submitted a merge request that could at least fix the problem for now by adding the ability to customize the cookie isSameSite.

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Feb 12, 2019

@AdriVanHoudt Got time to review and merge?

@hueniverse hueniverse added the request label Mar 1, 2019
@AdriVanHoudt AdriVanHoudt added this to the 9.5.0 milestone Mar 1, 2019
@Marsup Marsup added feature and removed request labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.