Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass back expires_in #49

Closed
jgallen23 opened this issue Dec 25, 2014 · 2 comments
Closed

pass back expires_in #49

jgallen23 opened this issue Dec 25, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@jgallen23
Copy link

@jgallen23 jgallen23 commented Dec 25, 2014

Google (along with others) pass back expires_in with the token and I'd like to store that to know when I should request a new token. It should be a very easy change to just add expires_in here: https://github.com/hapijs/bell/blob/master/lib/oauth.js#L213. Let me know if you want me to submit a pull request.

@ksck23

This comment has been minimized.

Copy link
Contributor

@ksck23 ksck23 commented Jan 12, 2015

Hi Team, i too felt that the "expiresIn: payload.expires_in" is a good to have parameter. Could you please confirm if this change has been accepted ?

@geek geek added the request label Feb 18, 2015
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Feb 18, 2015

@jgallen23 I'll accept a PR for that change. Thanks!

@geek geek added the feature label Apr 3, 2015
@geek geek added this to the 2.2.0 milestone Apr 3, 2015
@geek geek self-assigned this Apr 3, 2015
@geek geek closed this Apr 3, 2015
@Marsup Marsup removed the request label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.