Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook expiration won't be mapped properly #89

Closed
StephanGerbeth opened this issue May 24, 2015 · 3 comments · Fixed by #120
Closed

facebook expiration won't be mapped properly #89

StephanGerbeth opened this issue May 24, 2015 · 3 comments · Fixed by #120
Labels
bug
Milestone

Comments

@StephanGerbeth
Copy link

@StephanGerbeth StephanGerbeth commented May 24, 2015

Hi,

actually the expiration date of facebook access token won't be mapped properly.

You implemented a default mapping:
oauth.js - line 229: expiresIn: payload.expires_in

but the facebook payload attribute is called 'expires' only.

Cheers
Stephan

@geek geek added the bug label May 27, 2015
@kevindeasis

This comment has been minimized.

Copy link

@kevindeasis kevindeasis commented Jun 2, 2015

Im having issues with facebook expiraton as well. request.auth.credentials.expiresIn, this is undefined

@ldesplat ldesplat added this to the 5.0.1 milestone Jul 27, 2015
@ldesplat

This comment has been minimized.

Copy link
Contributor

@ldesplat ldesplat commented Jul 27, 2015

Anybody want to submit a PR?

Also, the spec specifies expires_in so I am surprised facebook is doing that. If the PR upgrades to the latest API and this still happens I could take a PR that fixes it.

ldesplat added a commit that referenced this issue Jul 29, 2015
Facebook Provider: Fix expiresIn, add example, backwards compatibility
Fixes #89
@ldesplat

This comment has been minimized.

Copy link
Contributor

@ldesplat ldesplat commented Jul 29, 2015

This should work now as of 5.0.1. We were not using the most up to date API endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.