Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POST payload format and location #92

Closed
hueniverse opened this issue May 27, 2015 · 0 comments · Fixed by #94
Closed

Fix POST payload format and location #92

hueniverse opened this issue May 27, 2015 · 0 comments · Fixed by #94
Assignees
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented May 27, 2015

The client resource() method puts POST payloads in the query. Also, some providers (I'm looking at your stupid face Twitter) require the form-encoded payload to be OAuth compliant which means strings with '!' will not get encoded using normal encoding and break. This fixes it in a way that will work under all versions of node.

If you didn't use the Bell.oauth.Client API, you are not affected by this change. If you did, you need to replace calls to client.request() with the new client.resource().

@hueniverse hueniverse self-assigned this May 27, 2015
@hueniverse hueniverse added this to the 2.9.1 milestone May 27, 2015
This was referenced May 27, 2015
@geek geek closed this in #94 May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.