Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clientSecret usage #101

Merged
merged 3 commits into from Jun 22, 2015
Merged

Fix clientSecret usage #101

merged 3 commits into from Jun 22, 2015

Conversation

@qualquervalor
Copy link

qualquervalor commented Jun 15, 2015

The code was attempting to access the clientSecret with the wrong variable name.

Chris Henney
@ulrikstrid

This comment has been minimized.

Copy link

ulrikstrid commented Jun 16, 2015

The second commit should probably not be in the same PR.

@qualquervalor qualquervalor force-pushed the qualquervalor:fixes branch from c3ff238 to bd20e14 Jun 16, 2015
@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Jun 16, 2015

@geek LGTM

@hofan41

This comment has been minimized.

Copy link
Contributor

hofan41 commented Jun 16, 2015

This was a rather large bug that somehow slipped through the unit tests. Wonder why the unit tests didn't catch this.

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Jun 16, 2015

Likely because tests use mock data. PRs adding more/better tests are always welcome.

@fson

This comment has been minimized.

Copy link

fson commented Jun 22, 2015

Could this be merged and a new release pushed to npm? It seems that most providers are broken at the moment.

@geek geek added the bug label Jun 22, 2015
@geek geek added this to the 4.0.1 milestone Jun 22, 2015
@geek geek self-assigned this Jun 22, 2015
geek added a commit that referenced this pull request Jun 22, 2015
Fix clientSecret usage
@geek geek merged commit b7f3442 into hapijs:master Jun 22, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.