Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clientSecret usage and adds test case #107

Merged
merged 5 commits into from Jun 22, 2015
Merged

Conversation

@qualquervalor
Copy link

qualquervalor commented Jun 19, 2015

This duplicate the fix from #101 and includes a proposed test case that would fail without the fix.

The previous suite of tests would complain if the user leaves off the clientSecret or gives it a value of undefined. But this particular bug happened at the point the clientSecret was assign as part of the query and then converted into a queryString. Since the wrong variable name was passed the query property client_secret was given a value of undefined. Then the queryString conversion method changed the undefined value into an empty string which is valid for a clientSecret.

@geek geek added the bug label Jun 22, 2015
@geek geek added this to the 4.0.1 milestone Jun 22, 2015
@geek geek self-assigned this Jun 22, 2015
geek added a commit that referenced this pull request Jun 22, 2015
 Fix clientSecret usage and adds test case
@geek geek merged commit 4bf59b7 into hapijs:master Jun 22, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.