Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying provider name in custom schema #11

Merged
merged 2 commits into from Aug 13, 2014

Conversation

@ggoodman
Copy link
Contributor

ggoodman commented Jun 18, 2014

Bell will not allow an application to use more than one 'custom' OAuth provider since doing so will result in conflicts to the provider's name / cookie / etc.

This change lets the implementer specify the provider name as a part of the provider schema.

Bell will not allow an application to use more than one 'custom' OAuth provider since doing so will result in conflicts to the provider's name / cookie / etc.

This change lets the implementer specify the provider name as a part of the provider schema.
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 18, 2014

Need to fix coverage and update docs.

@hueniverse hueniverse self-assigned this Jun 18, 2014
@ggoodman

This comment has been minimized.

Copy link
Contributor Author

ggoodman commented Jun 19, 2014

Hi @hueniverse I would be hapi to add the necessary tests but I'm quite honestly unsure where to start. Can you point me in the right direction? I will try and be on IRC today to chat.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 19, 2014

Something like this:

https://github.com/spumko/bell/blob/master/test/index.js#L127

Only instead of specifying cookie name, specify name.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jul 14, 2014

@ggoodman planning on finishing this?

@ggoodman

This comment has been minimized.

Copy link
Contributor Author

ggoodman commented Jul 14, 2014

Right. Will set aside some time for that.

@ggoodman

This comment has been minimized.

Copy link
Contributor Author

ggoodman commented Aug 4, 2014

@hueniverse sorry for the delay. This is my first real foray into TDD. Hope this looks good to you.

@hueniverse hueniverse added this to the 1.1.0 milestone Aug 13, 2014
hueniverse added a commit that referenced this pull request Aug 13, 2014
Allow specifying provider name in custom schema
@hueniverse hueniverse merged commit 2edf126 into hapijs:master Aug 13, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.