Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify additional query params for the profile request... #13

Merged
merged 2 commits into from Aug 13, 2014

Conversation

@dstevensio
Copy link

dstevensio commented Jul 4, 2014

... to the provider

I did so because I wanted to be able to get the user's profile picture from Facebook. I believe this gives a scalable way to do this, and I've tested it within my project to work as intended with that use case.

Tests included, verified 100% code coverage with npm test and updated the README to explain usage.

…est to the provider
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jul 14, 2014

Call these profileParams and add support for OAuth 1.0 too...

@hueniverse hueniverse self-assigned this Jul 14, 2014
@hueniverse hueniverse added this to the 1.1.0 milestone Jul 14, 2014
@jeffwhelpley

This comment has been minimized.

Copy link

jeffwhelpley commented Jul 16, 2014

Does this cover the Google OAuth 2.0 scope param?

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jul 16, 2014

@jeffwhelpley scope is already an option.

@jeffwhelpley

This comment has been minimized.

Copy link

jeffwhelpley commented Jul 16, 2014

@hueniverse, ah, sorry about that. I was just looking at the default Google implementation. I get it now.

hueniverse added a commit that referenced this pull request Aug 13, 2014
Added ability to specify additional query params for the profile request...
@hueniverse hueniverse merged commit a6e4a17 into hapijs:master Aug 13, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@dstevensio dstevensio deleted the dstevensio:additional-params branch Aug 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.