Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed linting issues // now extends lab linting #130

Merged
merged 1 commit into from Aug 20, 2015

Conversation

@AdriVanHoudt
Copy link
Contributor

AdriVanHoudt commented Aug 20, 2015

I added special rule def in test files because it was used so much that fixing it would take a lot of time and the rule is more a precaution anyway, so be carefull with you res's in your tests kids ❗️

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Aug 20, 2015

Thanks, I'll merge this once I figure out what is wrong with our tests. The last merged PR passed no problem :(

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented Aug 20, 2015

maybe a dep patch update or something?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented Aug 20, 2015

Will rebase soon

ldesplat added a commit that referenced this pull request Aug 20, 2015
fixed linting issues // now extends lab linting
@ldesplat ldesplat merged commit 658fbfa into hapijs:master Aug 20, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Aug 20, 2015

No need it does it automatically when it can.

@ldesplat ldesplat added the bug label Aug 20, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor Author

AdriVanHoudt commented Aug 20, 2015

👍

@ldesplat ldesplat added this to the 5.1.0 milestone Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.