Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong tests. OAuth1 does not include expiresIn for yahoo/bitbucke… #131

Merged
merged 1 commit into from Aug 20, 2015

Conversation

@ldesplat
Copy link
Contributor

ldesplat commented Aug 20, 2015

…t/twitter. Remove circular reference.

The tests were broken for a long time but upgraded dependencies and hoek > 2.11 uncovered those issues.

…t/twitter. Remove circular reference.
@ldesplat

This comment has been minimized.

Copy link
Contributor Author

ldesplat commented Aug 20, 2015

Travis fails because of linting issues which are partially fixed in #130

ldesplat added a commit that referenced this pull request Aug 20, 2015
Fix wrong tests. OAuth1 does not include expiresIn for yahoo/bitbucke…
@ldesplat ldesplat merged commit 42696e1 into hapijs:master Aug 20, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Aug 20, 2015

Nice was thinking about doing a dep update but I was waiting for the tests to be fixed :D

@ldesplat ldesplat added bug test labels Aug 20, 2015
@ldesplat ldesplat added this to the 5.1.0 milestone Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.