Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v4 #137

Merged
merged 1 commit into from Sep 9, 2015
Merged

Node v4 #137

merged 1 commit into from Sep 9, 2015

Conversation

@ldesplat
Copy link
Contributor

ldesplat commented Sep 9, 2015

No description provided.

ldesplat added a commit that referenced this pull request Sep 9, 2015
Node v4
@ldesplat ldesplat merged commit 1da7e32 into hapijs:master Sep 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Sep 9, 2015

Don't forget the sudo false to take advantage of new travis infrastructure.

@Marsup Marsup added the test label Sep 9, 2015
@ldesplat

This comment has been minimized.

Copy link
Contributor Author

ldesplat commented Sep 9, 2015

Thank you, did not know :)

@@ -2,5 +2,4 @@ language: node_js

node_js:
- 0.10
- 0.12

This comment has been minimized.

Copy link
@jalcine

jalcine Sep 9, 2015

Why not still support 0.12?

This comment has been minimized.

Copy link
@ldesplat

ldesplat Sep 9, 2015

Author Contributor

Hapi never really supported 0.12.
See outmoded/discuss#85

We will not support 0.12 as there is no point. Moving to 0.12 is not worth the effort from 0.10 which is the most stable, battle tested version. As for io.js, once v4.0 is out and is the new official version of node.js, we will start testing against it. Beyond this, it is hard to say.

This comment has been minimized.

Copy link
@jalcine

jalcine Sep 9, 2015

@ldesplat commented on Sep 9, 2015, 5:27 PM EDT:

Hapi never really supported 0.12.

See hapijs/discuss#85

We will not support 0.12 as there is no point. Moving to 0.12 is not worth the effort from 0.10 which is the most stable, battle tested version. As for io.js, once v4.0 is out and is the new official version of node.js, we will start testing against it. Beyond this, it is hard to say.

Good to know!

@ldesplat ldesplat added this to the 5.2.0 milestone Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.