Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitbucket to use the oAuth2 endpoint #174

Merged
merged 4 commits into from Jan 6, 2016
Merged

Conversation

@mattapperson
Copy link
Contributor

mattapperson commented Dec 30, 2015

No description provided.

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Dec 30, 2015

Very nice!

Two things:

  1. The tests are failing so ensure you update them. In this case I think they just need to be told to expect oauth2 mocks.
    bitbucket
    ✖63) authenticates with mock
    ✖64) authenticates with mock (last_name is empty)
  2. Please also update the documentation in Providers.md
    https://github.com/hapijs/bell/blob/master/Providers.md#bitbucket

Thanks!

Matt Apperson added 3 commits Dec 30, 2015
Matt Apperson
Matt Apperson
ldesplat added a commit that referenced this pull request Jan 6, 2016
Update bitbucket to use the oAuth2 endpoint
@ldesplat ldesplat merged commit 0041e93 into hapijs:master Jan 6, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ldesplat ldesplat added this to the 6.1.0 milestone Jan 6, 2016
@ldesplat ldesplat added the feature label Jan 6, 2016
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Jan 6, 2016

Thank you very much. You should have put a comment, I completely missed this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.