Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipProfile option #183

Merged
merged 3 commits into from Feb 14, 2016
Merged

skipProfile option #183

merged 3 commits into from Feb 14, 2016

Conversation

@bbatliner
Copy link
Contributor

bbatliner commented Feb 7, 2016

There are some cases when I want to use bell with OAuth scopes that don't include the profile. For example, I'm using the Google Calendar scope, but not the profile scope, so bell wouldn't be able to fetch the profile. This lets the user skip fetching the profile from their provider config, without having to write a new provider with their blank profile function.

@ldesplat ldesplat added this to the 6.2.0 milestone Feb 7, 2016
@ldesplat ldesplat added the feature label Feb 7, 2016
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Feb 7, 2016

So, some providers give you the option of extendedProfile: true/false. Feels like the Google one (and really all of them) should definitely implement that.

Now I think I also understand the use case for this but let me fully understand the impact. I don't like how there are no additional tests and somehow you are getting 100% test coverage.. something is not right.

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Feb 7, 2016

Also, need docs for this PR in API.md :)

@bbatliner

This comment has been minimized.

Copy link
Contributor Author

bbatliner commented Feb 8, 2016

Hey @ldesplat, thanks for the feedback. I updated the API and added a couple tests for oauth v1 and v2 with skipProfile. Let me know if there's anything else I can do!

@ldesplat ldesplat modified the milestones: 6.3.0, 6.2.0 Feb 14, 2016
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Feb 14, 2016

Thanks! Will go through it today.

ldesplat added a commit that referenced this pull request Feb 14, 2016
skipProfile option
@ldesplat ldesplat merged commit 8b9e5de into hapijs:master Feb 14, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Feb 14, 2016

It is now in 6.3.0. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.