Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket incorrect id and styling inconsistency. #196

Merged
merged 1 commit into from Mar 8, 2016

Conversation

@pygeek
Copy link
Contributor

pygeek commented Mar 7, 2016

Not sure why this wasn't picked up in the PR, but there are a couple issues.

  1. It seems profile.uuid should be used instead of profile.username for credentials.profile.id.
  2. The style in which this was written differs from the other providers we have.

I've gone ahead and fixed both issues in this PR.

@pygeek pygeek force-pushed the pygeek:patch-1 branch from d6f8013 to 5bf6538 Mar 7, 2016
.gitignore Outdated
@@ -16,3 +16,8 @@ config.json
coverage.*
lib-cov
complexity.md

#Ignore vim temporary and swap files

This comment has been minimized.

Copy link
@gergoerdosi

gergoerdosi Mar 7, 2016

Add these to your global gitignore that is specific to your environment, not to the project specific one. See more information here:

https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Mar 7, 2016

Just remove your .gitignore file changes from this PR and I can merge this in.

Looking at the docs, it looks like v1 of the user endpoint only returned username and no uuid so maybe this is why? Thanks I'll merge it as soon as you make that change.

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Mar 7, 2016

I forgot, please update the documentation in Providers.md which has the same "bug"

@ldesplat ldesplat added the bug label Mar 7, 2016
@ldesplat ldesplat added this to the 7.1.1 milestone Mar 7, 2016
Not sure why this wasn't picked up in the PR, but there are a couple issues.
1. It seems `profile.uuid` should be used instead of `profile.username` for `credentials.profile.id`.
2. The style in which this was written differs from the other providers we have.

I've gone ahead and fixed both issues in this PR.

Update Provider documentation.
@pygeek pygeek force-pushed the pygeek:patch-1 branch from 5bf6538 to 3afa869 Mar 7, 2016
@pygeek

This comment has been minimized.

Copy link
Contributor Author

pygeek commented Mar 7, 2016

I reverted the changes to the .gitignore and updated Providers.md—nice catch.

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Mar 8, 2016

Thank you very much :) I'll make a release tomorrow.

ldesplat added a commit that referenced this pull request Mar 8, 2016
Bitbucket incorrect id and styling inconsistency.
@ldesplat ldesplat merged commit ecd51ef into hapijs:master Mar 8, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ldesplat ldesplat modified the milestones: 7.2.0, 7.1.1 Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.