Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently return node req object in oauth v1 client. Closes #215 #216

Merged
merged 1 commit into from May 16, 2016

Conversation

@hueniverse
Copy link
Member

hueniverse commented May 15, 2016

This might benefit from some tests confirming that all these methods return a node req object. This is needed in case you want to req.abort() etc. I don't have the time to add tests but this is probably worth merging and adding a new issue for the missing tests...

@hueniverse hueniverse added the bug label May 15, 2016
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented May 16, 2016

I can't believe we don't even allow users to specify a timeout in request options or even send special headers (for tracking purposes) and such. Definitely something to improve upon.

Thanks! :)

@ldesplat ldesplat merged commit 1c65521 into master May 16, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ldesplat ldesplat added this to the 7.7.0 milestone May 16, 2016
@hueniverse hueniverse deleted the wreck branch May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.