Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix markup to quote URL correctly to avoid infinite redirect #225
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thank you for finding this. What a bad bug, from such a simple mistake. |
This comment has been minimized.
This comment has been minimized.
|
No worries! Thank you for the quick review + merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
akshayp commentedJun 1, 2016
•
edited
@ldesplat After the fix for #208 it looks like at least on chrome it's possible to simulate an infinite redirect. It's triggered by unbalanced quotes used in the markup which make the current browser location be the redirect url without the refresh param. I've updated the markup to be similar to the W3 Example to avoid the infinite redirect