Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markup to quote URL correctly to avoid infinite redirect #225

Merged
merged 1 commit into from Jun 2, 2016

Conversation

@akshayp
Copy link
Contributor

akshayp commented Jun 1, 2016

@ldesplat After the fix for #208 it looks like at least on chrome it's possible to simulate an infinite redirect. It's triggered by unbalanced quotes used in the markup which make the current browser location be the redirect url without the refresh param. I've updated the markup to be similar to the W3 Example to avoid the infinite redirect

@ldesplat ldesplat added this to the 7.7.2 milestone Jun 2, 2016
@ldesplat ldesplat added the bug label Jun 2, 2016
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Jun 2, 2016

Thank you for finding this. What a bad bug, from such a simple mistake.

@ldesplat ldesplat merged commit 30309c5 into hapijs:master Jun 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ldesplat ldesplat modified the milestones: 7.7.3, 7.7.2 Jun 2, 2016
@akshayp

This comment has been minimized.

Copy link
Contributor Author

akshayp commented Jun 2, 2016

No worries! Thank you for the quick review + merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.