Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAphuang2013 patch 1 #236
Merged
Aphuang2013 patch 1 #236
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thank you! Also thanks to @cvillerm and @PaulMougel for helping & reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aphuang2013 commentedJun 16, 2016
could not figure out how to rebase the stuff, so I delete my old fork, restart with the master and integrate with changes. It passed the coverage test now.