Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter additional GET parameters on extended profile request #249

Merged
merged 3 commits into from Aug 20, 2016

Conversation

@bbatliner
Copy link
Contributor

bbatliner commented Aug 5, 2016

I was trying to retrieve the email of Twitter users and found it on this API route. However, fetching the email from this route requires an additional GET parameter. This PR allows for additional parameters to that extended profile call.

Questions I have:

  1. When writing the test for this option, I couldn't find a way in the Mock'd Twitter endpoint to verify if there were actual GET parameters passed to that route. Is this something that's testable?
  2. Should dynamic GET parameters (via a function in the config) be allowed? In my use case, I only needed to add "include_email": "true", but other parameters might be dependent on the authenticated user's information.

Thanks!

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Aug 20, 2016

Thank you, this looks really useful. For dynamic parameters, nobody has asked for it and if they really want to, they can make their own profile call or submit a PR.

@ldesplat ldesplat merged commit 7293af0 into hapijs:master Aug 20, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ldesplat ldesplat added the feature label Aug 20, 2016
@ldesplat ldesplat added this to the 8.1.0 milestone Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.