Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Updates Facebook provider to v2.7 #252

Closed
wants to merge 7 commits into from

Conversation

@kamronbatman
Copy link
Contributor

kamronbatman commented Aug 15, 2016

Updates Facebook provider to v2.7.
Tested with public profile options and is working.

kamronbatman added 4 commits Aug 5, 2016
Updates facebook API mocks to v2.7
Update facebook oAuth tests.
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Aug 20, 2016

For reference this is the changelog between the APIs.. In this case going from 2.3 (supported until July 2017) to 2.7.

https://developers.facebook.com/docs/apps/changelog

Take a look at the changes in permissions, would explain the changes. In our case, it doesn't impact us but it does impact if people are passing in extra permissions which leads me to think that this is a breaking change for our users.

I'll merge this in a major release but I am going on vacation for 8 days so it will have to wait that much extra time for now!

@ldesplat ldesplat added this to the 9.0.0 milestone Aug 20, 2016
@ldesplat ldesplat added the feature label Aug 20, 2016
@kamronbatman

This comment has been minimized.

Copy link
Contributor Author

kamronbatman commented Aug 23, 2016

Going from v2.3 to v2.7 is a big change. There are a few deprecations and permission changes but that is minor compared to the improved performance and new endpoints/APIs.

Should we allow the user to specify the version through a field? The Facebook provider is fairly simple and I think it can already support 2.x.

@hueniverse hueniverse removed this from the 9.0.0 milestone Dec 1, 2016
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Feb 6, 2017

It will get done :) He removed it because he was doing a release of something else.

Thank you for being so very patient!

@kamronbatman

This comment has been minimized.

Copy link
Contributor Author

kamronbatman commented Feb 6, 2017

I realized that and that is why I removed my comment. I updated it to the latest master. I figure we can rebase or squash when ready. Also since facebook v2.8 is out, this might be outdated and need to be replaced with a new PR that has new testing.

@ldesplat ldesplat added this to the 9.0.0 milestone Mar 24, 2017
@kamronbatman

This comment has been minimized.

Copy link
Contributor Author

kamronbatman commented Apr 26, 2017

Now that Facebook has moved beyond v2.7, should we consider a newer API version for the next milestone?

@kamronbatman

This comment has been minimized.

Copy link
Contributor Author

kamronbatman commented Apr 26, 2017

Closing this out in favor of #311.

@ldesplat ldesplat modified the milestones: 9.0.0, 8.7.0 Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.