Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes #266 Implements azure active directory as bell azuread module #267
@sudheesh001 Thank you so much for the contribution!
I know it is minor, but can you please fix the linting?
Thank you! Now, once you understand how the tests are done, I think you could make this PR 100% good to go :)
See https://github.com/hapijs/bell/blob/master/test/providers/google.js#L45 as a reference. You will see I've highlighted Line 45 which basically tells you that we mock all the responses. This is done because the tests run fast & more importantly we don't have a proper way to store & share secrets so that we can run our tests directly against the providers.
So the gist of it is copy another test for one of the providers. Change the profile mock to reflect what azuread would respond with and then https://github.com/hapijs/bell/blob/master/test/providers/google.js#L45 change what we should be expecting as results.
That's it. That usually covers everything. I don't see any if checks in your code so 1 test will suffice.
When users wants to use this, just put