Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #261 expose OAUTH2 token response as request.auth.artifacts #273

Merged
merged 1 commit into from Mar 24, 2017

Conversation

@garthk
Copy link

garthk commented Oct 13, 2016

OpenId Connect providers return an ID token in the id_token property of
their token response, e.g. auth0 with scope: ['openid']. This
change caters for any scenario requiring unexpected properties from the
token response by exposing the full token payload as
request.auth.artifacts.

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Oct 17, 2016

That looks good to me on first view. Let me play with it this week.

@ldesplat ldesplat added this to the 8.4.0 milestone Oct 17, 2016
@ldesplat ldesplat added the feature label Oct 17, 2016
@hueniverse hueniverse removed this from the 8.4.0 milestone Dec 1, 2016
OpenId Connect providers return an ID token in the `id_token` property of
their `token` response, e.g. `auth0` with `scope: ['openid']`. This
change caters for any scenario requiring unexpected properties from the
`token` response by exposing the full `token` payload as
`request.auth.artifacts`.
@garthk garthk force-pushed the garthk:return_artifacts branch from f744f90 to 89366ac Feb 22, 2017
@garthk

This comment has been minimized.

Copy link
Author

garthk commented Feb 22, 2017

Rebased.

@jsatk

This comment has been minimized.

Copy link
Contributor

jsatk commented Feb 27, 2017

I'd love to see this get merged. We would need something like this for our uses. I opened a PR to add Okta and referenced this PR in it. #299

@ldesplat ldesplat added this to the 8.6.0 milestone Mar 13, 2017
@ldesplat ldesplat merged commit 63603c9 into hapijs:master Mar 24, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.