Skip to content

/bell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook #303

Closed
wants to merge 1 commit into from
Closed

Facebook #303

wants to merge 1 commit into from

Conversation

@doron2402
Copy link
Contributor

doron2402 commented Mar 21, 2017

  • Using Facebook newest api version (2.8)
  • Adding user picture to request
@doron2402
using the Facebook newest api version, adding picture to user profile
Loading status checks…
83fb5d7
@AdriVanHoudt

This comment has been minimized.

Sign in to view
Copy link
Contributor

AdriVanHoudt commented Mar 21, 2017

is there anything breaking about the upgrade to 2.8? would existing implementations just keep working?
@doron2402

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

doron2402 commented Mar 21, 2017

@AdriVanHoudt ,
not that I know of but I've updated that locally and it seems to be working fine.
@ldesplat ldesplat added this to the 9.0.0 milestone Mar 24, 2017
@kamronbatman

This comment has been minimized.

Sign in to view
Copy link
Contributor

kamronbatman commented Apr 26, 2017 •
edited

First, we should look into v2.9, which doesn't look like it has anything breaking between v2.7 and v2.8. Also this PR requires updates to oauth.js and tests.

Recommend closing this in favor of #311.
@kamronbatman kamronbatman mentioned this pull request Apr 26, 2017
Merged
@ldesplat

This comment has been minimized.

Sign in to view
Copy link
Contributor

ldesplat commented May 9, 2017

#311 got merged which takes care of this. I know I took a very long time, but thank you so much for persevering :)
@ldesplat ldesplat closed this May 9, 2017
@ldesplat ldesplat modified the milestones: 9.0.0, 8.7.0 Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  8.7.0
4 participants
@doron2402 @AdriVanHoudt @kamronbatman @ldesplat
You can’t perform that action at this time.