Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitbucket provider #31

Merged
merged 1 commit into from Oct 8, 2014
Merged

Add bitbucket provider #31

merged 1 commit into from Oct 8, 2014

Conversation

@salzhrani
Copy link
Contributor

salzhrani commented Oct 5, 2014

pending a live test. will do soon.

@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented Oct 6, 2014

gettings the user profile fails. It seems that bitbucket requires oauth_version to be set to 1.0 when making authetication calls, when I add it here the profile request works fine. any advice ?

@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented Oct 6, 2014

I opened an issue at bitbucket since oauth_version is optional.
https://bitbucket.org/site/master/issue/10456/not-including-oauth_version-in-requests

@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented Oct 6, 2014

Added a workaround to be removed when bitbucket updates their API.

@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented Oct 7, 2014

Any advice @geek ?

@geek geek added the feature label Oct 7, 2014
@geek

This comment has been minimized.

Copy link
Member

geek commented Oct 7, 2014

@salzhrani mind reworking the oauth client request code to optionally accept and add the version to the request?

@geek geek added the request label Oct 7, 2014
Samy Alzhrani
Modify Client to accept version number
@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented Oct 8, 2014

Done.

@salzhrani salzhrani force-pushed the salzhrani:bitbucket branch from 435fe78 to 00e9118 Oct 8, 2014
@geek geek added this to the 1.1.1 milestone Oct 8, 2014
@geek geek self-assigned this Oct 8, 2014
@geek geek removed the request label Oct 8, 2014
geek added a commit that referenced this pull request Oct 8, 2014
Add bitbucket provider
@geek geek merged commit 6ff8ffa into hapijs:master Oct 8, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@salzhrani salzhrani deleted the salzhrani:bitbucket branch Oct 8, 2014
@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented Oct 16, 2014

A friendly reminder

@geek

This comment has been minimized.

Copy link
Member

geek commented Oct 16, 2014

@salzhrani this is now published as 1.2.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.