Added mixer provider #314
Added mixer provider #314
Conversation
lib/providers/mixer.js
Outdated
| token: uri + 'api/v1/oauth/token', | ||
| scope: ['user:details:self'], | ||
| useParamsAuth: true, | ||
| scopeSeparator: ',', |
There was a problem hiding this comment.
Not used by default, but this should be a space. We follow the spec properly :)
There was a problem hiding this comment.
what is not used by default? and yes, just got a message in discord, sorry.
There was a problem hiding this comment.
The default scope is set to user:details:self, so there's not multiple scopes to separate. However if a consumer overrides this and requests additional scopes, they'll get rejected.
|
https://travis-ci.org/hapijs/bell/jobs/238105605 Is that an issue on my side? |
yarn.lock
Outdated
| @@ -0,0 +1,1294 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
oh no, that got generated when i installed the needed dependencies with yarn, thought that is already in the .gitignore, removing it asap.
| options = options || {}; | ||
|
|
||
| const uri = options.uri || 'https://mixer.com'; | ||
| const user = options.uri ? options.uri + '/api/v1/users/current' : 'https://mixer.com/api/v1/users/current'; |
There was a problem hiding this comment.
This should probably just be:
const user = uri + '/api/v1/users/current';
|
Thank you for this, it's now merged through #314 |
Tested, seems like it is working. Would appreciate it when someone else could test it.