Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stripe as a new provider #316

Merged
merged 1 commit into from Sep 24, 2017
Merged

Add Stripe as a new provider #316

merged 1 commit into from Sep 24, 2017

Conversation

@sholladay
Copy link
Contributor

sholladay commented Jun 26, 2017

Time to make some $$$, yo.

This PR adds Stripe, one of the most popular payment platforms, as a new provider. With this, we can use Stripe Connect to help sellers sign up or log in to our platform and earn a living.

Stripe OAuth docs: https://stripe.com/docs/connect/oauth-reference

@sholladay

This comment has been minimized.

Copy link
Contributor Author

sholladay commented Jul 2, 2017

Anyone have time for a review? @ldesplat @Marsup

Should be pretty uncontroversial. 🤞

@sholladay

This comment has been minimized.

Copy link
Contributor Author

sholladay commented Sep 2, 2017

@nlf I think this module needs a new maintainer.

@nlf

This comment has been minimized.

Copy link
Member

nlf commented Sep 2, 2017

it appears you may be correct

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Sep 2, 2017

Already tried in #253, no one showed up, are you candidate ?

@ldesplat ldesplat added the feature label Sep 24, 2017
@ldesplat ldesplat added this to the 8.8.0 milestone Sep 24, 2017
@ldesplat ldesplat merged commit edc7a37 into hapijs:master Sep 24, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Sep 24, 2017

Thanks :) You asked for controversial and you got it! I am definitely not the best person to maintain bell anymore as can be seen in how slow I merge this. But all your efforts are very appreciated.

@sholladay

This comment has been minimized.

Copy link
Contributor Author

sholladay commented Sep 24, 2017

Better late than never. Also, I just want to say thanks for the time and effort you have put in. Open source is important but often with little tangible reward. I appreciate it. ❤️

If I were more familiar with OAuth, I would potentially volunteer to be maintainer. Not sure I'm a good fit right now, but I will spread the word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.