Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mixer as a new provider #318

Merged
merged 5 commits into from Sep 24, 2017
Merged

Add Mixer as a new provider #318

merged 5 commits into from Sep 24, 2017

Conversation

@NickParks
Copy link
Contributor

NickParks commented Jul 19, 2017

Tested this last night and it worked fine, apologizes if there's anything different in the test file. Haven't created many of those myself.

NickParks added 4 commits Jul 19, 2017
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Jul 19, 2017

There is also #314 any difference in the PR's?

@NickParks

This comment has been minimized.

Copy link
Contributor Author

NickParks commented Jul 19, 2017

I haven't tested the other PR myself, but from looking at the code differences it looks like mine just passes the Travis CI check, doesn't include anything about yarn, has the mixer require placed alphabetically along with the rest in the providers index, and is a little cleaner looking (personal preference I suppose).

Other than that both should be functional.

@NickParks

This comment has been minimized.

Copy link
Contributor Author

NickParks commented Aug 12, 2017

Any news on this? Would love to see it officially included in bell :)

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Aug 16, 2017

cc @ldesplat

@ldesplat ldesplat added this to the 8.8.0 milestone Sep 24, 2017
@ldesplat ldesplat added the feature label Sep 24, 2017
@ldesplat ldesplat merged commit f881ac3 into hapijs:master Sep 24, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Sep 24, 2017

Thank you! And thanks for being super patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.