Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing the location option to be a function #319

merged 4 commits into from Sep 24, 2017


Copy link

dpmott commented Jul 27, 2017

Addresses some of the need described in #184.

Specifically, I need this to avoid appending the request.path to the redirect URI, because I'm working with an OAuth2 provider that forbids any path (even a trailing slash).

@@ -73,7 +73,10 @@ internals.schema = Joi.object({
profileParams: Joi.object(),
skipProfile: internals.flexBoolean.optional().default(false),
forceHttps: internals.flexBoolean.optional().default(false),
location: Joi.string().optional().default(false),
location: Joi.alternatives().try(

This comment has been minimized.

Copy link

ldesplat Sep 24, 2017


This does do the same thing as it did before in the case of not specifying a location. As in, without a location option, location will be undefined. I'll fix that since it's easy.

@ldesplat ldesplat added the feature label Sep 24, 2017
@ldesplat ldesplat added this to the 8.8.0 milestone Sep 24, 2017
@ldesplat ldesplat merged commit d7a41e6 into hapijs:master Sep 24, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.