Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Hapi 17 Support #332

Closed
wants to merge 9 commits into from
Closed

Conversation

@ChristianMurphy
Copy link

ChristianMurphy commented Nov 10, 2017

TODO:

  • leverage async and await
  • leverage destructured assignment
  • Update linter to allow async arrow functions
  • Identify remaining gaps

resolves #330

@ChristianMurphy ChristianMurphy force-pushed the ChristianMurphy:hapi-17 branch 2 times, most recently from 2824293 to d2e4967 Nov 10, 2017
@@ -1,21 +1,15 @@
language: node_js

node_js:
- "4"
- "6"

This comment has been minimized.

Copy link
@Marsup

Marsup Nov 10, 2017

Member

Also add "9".

This comment has been minimized.

Copy link
@ChristianMurphy

ChristianMurphy Nov 10, 2017

Author

Added

API.md Outdated
var server = new Hapi.Server();
server.connection({ port: 8000 });
var server = new Hapi.Server({ port: 8000 });

This comment has been minimized.

Copy link
@Marsup

Marsup Nov 10, 2017

Member

Hapi 17 doesn't need a new.

This comment has been minimized.

Copy link
@ChristianMurphy
},
"scripts": {
"test": "node node_modules/lab/bin/lab -t 100 -L -v",
"test-cov-html": "node node_modules/lab/bin/lab -r html -o coverage.html -L"
"test": "lab -t 100 -L -v",

This comment has been minimized.

Copy link
@Marsup

Marsup Nov 10, 2017

Member

Should probably add back -a code to both since lab is back to no default assertion library.

This comment has been minimized.

Copy link
@ChristianMurphy
var server = new Hapi.Server();
server.connection({ port: 8000 });
var { Server } = require('hapi');

This comment has been minimized.

Copy link
@Marsup

Marsup Nov 10, 2017

Member

Might as well use consts and other ES6 features wherever possible now.

This comment has been minimized.

Copy link
@ChristianMurphy

ChristianMurphy Nov 10, 2017

Author

Updated to const
Will be leveraging more ES6 features in the next few refactors.

@ldesplat ldesplat added this to the 9.0.0 milestone Nov 19, 2017
@ldesplat ldesplat force-pushed the ChristianMurphy:hapi-17 branch from 1e3c5b7 to 79dcee4 Nov 19, 2017
@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Nov 19, 2017

I mistakenly pushed to your branch but I forced it back to what it was :)

This hapi 17 upgrade is very non trivial for bell and all its tests.

@ldesplat ldesplat mentioned this pull request Nov 19, 2017
@ChristianMurphy ChristianMurphy force-pushed the ChristianMurphy:hapi-17 branch from 79dcee4 to 130368d Nov 19, 2017
@ChristianMurphy

This comment has been minimized.

Copy link
Author

ChristianMurphy commented Nov 29, 2017

Closing, in favor of #334

@ChristianMurphy ChristianMurphy deleted the ChristianMurphy:hapi-17 branch Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.