Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture object included in the profile object for facebook oauth #350

Merged
merged 4 commits into from Mar 8, 2018

Conversation

@satnam-sandhu
Copy link
Contributor

satnam-sandhu commented Mar 6, 2018

Hi @AdriVanHoudt ,
Finally after changing the picture fields' value from just the url to a object i am able to pass the tests.
Sorry for bothering you again, but this time it seems to be working fine.
Thank you. :)

Copy link
Contributor

AdriVanHoudt left a comment

Does profile.picture in the implementation match the picture object from your tests?
If so we're good to go, if not it should and we might need to change some of the tests to accommodate the change (which is fine)

@satnam-sandhu

This comment has been minimized.

Copy link
Contributor Author

satnam-sandhu commented Mar 7, 2018

Yes it does match the test. I have modified the tests accordingly.

Copy link
Contributor

AdriVanHoudt left a comment

LGTM then :D 🎉

@hueniverse hueniverse self-assigned this Mar 8, 2018
@hueniverse hueniverse added the feature label Mar 8, 2018
@hueniverse hueniverse added this to the 9.2.0 milestone Mar 8, 2018
@hueniverse hueniverse merged commit aa8cc43 into hapijs:master Mar 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.