Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OIDC compliant profile from Auth0 #358

Merged
merged 2 commits into from Apr 16, 2018
Merged

Conversation

@sholladay
Copy link
Contributor

sholladay commented Apr 11, 2018

This tiny change ensures that Auth0 won't break for bell users when Auth0 replaces their legacy user profile endpoint with an OIDC compliant one.

Note that this change does not require any action on the part of the user and it is backwards compatible because Auth0 is already returning profile.sub in addition to the old profile.user_id in order to make it easier to transition.

Copy link
Contributor

AdriVanHoudt left a comment

@sholladay

This comment has been minimized.

Copy link
Contributor Author

sholladay commented Apr 13, 2018

Done. :)

@AdriVanHoudt AdriVanHoudt self-assigned this Apr 16, 2018
@AdriVanHoudt AdriVanHoudt added this to the 9.3.1 milestone Apr 16, 2018
@AdriVanHoudt AdriVanHoudt merged commit 1c281c5 into hapijs:master Apr 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Apr 16, 2018

Thank you!
Do you need this change quickly? Otherwise I will queue it up with other changes for the release.

@sholladay

This comment has been minimized.

Copy link
Contributor Author

sholladay commented Apr 16, 2018

Nope, no hurry. Auth0 is not forcing OIDC onto anyone for at least the next couple of months. This change is mostly to make bell more future proof, in light of the fact that the old way is officially deprecated.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Apr 16, 2018

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.