Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB custom scope + upgrade api version #381

Merged
merged 1 commit into from Oct 10, 2018

Conversation

@doron2402
Copy link
Contributor

doron2402 commented Oct 3, 2018

  • Upgrade FB version from 2.9 to 3.1
  • Add the ability to update Facebook login scope
@doron2402

This comment has been minimized.

Copy link
Contributor Author

doron2402 commented Oct 4, 2018

@AdriVanHoudt anything I should add?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Oct 8, 2018

@doron2402 looks good, is there a breaking api change between these versions?

@AdriVanHoudt AdriVanHoudt self-assigned this Oct 8, 2018
@AdriVanHoudt AdriVanHoudt added the feature label Oct 8, 2018
@doron2402

This comment has been minimized.

Copy link
Contributor Author

doron2402 commented Oct 8, 2018

thanks @AdriVanHoudt did some testing and double checked Facebook api docs seems fine:
https://developers.facebook.com/docs/graph-api/reference/v3.1/user

@doron2402 doron2402 closed this Oct 8, 2018
@doron2402

This comment has been minimized.

Copy link
Contributor Author

doron2402 commented Oct 8, 2018

oops I mean to comment not to close it.

@edisoncruz

@doron2402 doron2402 reopened this Oct 8, 2018
@doron2402

This comment has been minimized.

Copy link
Contributor Author

doron2402 commented Oct 9, 2018

@AdriVanHoudt can we merge this?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Oct 10, 2018

I can only see https://developers.facebook.com/docs/graph-api/changelog/version3.0#login which I don't think is breaking in our case.

@AdriVanHoudt AdriVanHoudt added this to the 10.0.0 milestone Oct 10, 2018
@AdriVanHoudt AdriVanHoudt merged commit 5a5780e into hapijs:master Oct 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse hueniverse modified the milestones: 10.0.0, 9.3.2 Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.