Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LinkedIn to use new lite profile #391

Merged
merged 6 commits into from Mar 5, 2019

Conversation

@dawnerd
Copy link
Contributor

dawnerd commented Jan 15, 2019

Changes

  • Switched to use the new liteprofile scope
  • Grabs email from new dedicated endpoint

Will be testing this in another app tomorrow just to make sure I didn't miss anything.

Note: I had to update mock to support overriding both the endpoints - not sure if thats the best way...

Resolves #390

@dawnerd

This comment has been minimized.

Copy link
Contributor Author

dawnerd commented Feb 4, 2019

@AdriVanHoudt Can we get some eyes on this soon?

@AdriVanHoudt AdriVanHoudt self-assigned this Feb 25, 2019
@dawnerd

This comment has been minimized.

Copy link
Contributor Author

dawnerd commented Feb 26, 2019

Got around to trying it out and had to make a fix, looks like they're using standard oauth now. Their docs are also a bit wrong with getting the email.

Copy link
Contributor

AdriVanHoudt left a comment

Your fixes seems correct apart from 2 I think, thanks for looking into this!

lib/providers/linkedin.js Show resolved Hide resolved
test/mock.js Show resolved Hide resolved
Copy link
Contributor

AdriVanHoudt left a comment

LGTM

@AdriVanHoudt AdriVanHoudt merged commit 8005df9 into hapijs:master Mar 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AdriVanHoudt AdriVanHoudt added this to the 10.0.0 milestone Mar 5, 2019
@AdriVanHoudt AdriVanHoudt mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.