Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow isSameSite customization #396

Merged
merged 1 commit into from Feb 25, 2019
Merged

Allow isSameSite customization #396

merged 1 commit into from Feb 25, 2019

Conversation

@flippidippi
Copy link
Contributor

flippidippi commented Feb 11, 2019

Fixes #395 by allowing customization of the isSameSite param.

Phillip Lanclos
Copy link
Member

Nargonath left a comment

LGTM

@AdriVanHoudt AdriVanHoudt self-assigned this Feb 25, 2019
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Feb 25, 2019

Looks good, thanks!

Is it ok if we only allow false, Lax or Strict since those are the only ones allowed by hapi?

@AdriVanHoudt AdriVanHoudt merged commit 48ac042 into hapijs:master Feb 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@flippidippi

This comment has been minimized.

Copy link
Contributor Author

flippidippi commented Feb 25, 2019

@AdriVanHoudt Yeah I had thought about that, but I wasn't sure what the standard was. Since hapi will catch that, I figured it was less maintenance if we make the rule more lax in bell.

@flippidippi

This comment has been minimized.

Copy link
Contributor Author

flippidippi commented Feb 26, 2019

Is there a timeline of when the next release will be?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Feb 26, 2019

I got caught up in looking into supporting hapi 18 but if you want I can do a minor release to get this out before that.

@flippidippi

This comment has been minimized.

Copy link
Contributor Author

flippidippi commented Feb 26, 2019

That would be sweeeeeet.

AdriVanHoudt added a commit that referenced this pull request Feb 26, 2019
@AdriVanHoudt AdriVanHoudt added this to the 9.5.0 milestone Feb 26, 2019
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Feb 26, 2019

Done 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.