Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hapi 18 #397

Merged
merged 3 commits into from Feb 27, 2019
Merged

Add support for hapi 18 #397

merged 3 commits into from Feb 27, 2019

Conversation

@rluba
Copy link
Contributor

rluba commented Feb 27, 2019

This PR includes two fixes related to hapi 18:

  1. Many tests broke because hapi now strips the default port from request.info.host (a side effect of using the WHATWG URL API) – causing lots of assertions to fail. I decided to use a non-default port in the tests instead of removing the default port from the assertions. This verifies that port info is still propagated correctly.
  2. request.url.query is no longer available. I’ve changed it to request.query which works for hapi 18 and older versions. (I’ve tested it with hapi 17 and 18). This fixes #394.
@rluba rluba mentioned this pull request Feb 27, 2019
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Feb 27, 2019

This is amazing, thank you!

@AdriVanHoudt AdriVanHoudt self-assigned this Feb 27, 2019
@AdriVanHoudt AdriVanHoudt added this to the 9.5.1 milestone Feb 27, 2019
@AdriVanHoudt AdriVanHoudt merged commit 5c28ac3 into hapijs:master Feb 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rluba

This comment has been minimized.

Copy link
Contributor Author

rluba commented Feb 28, 2019

@AdriVanHoudt You’re welcome. Thank you for maintaining this project. 🙇‍♂

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 1, 2019

No problem! It is PR's like this that make it possible :O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.